Make yaml output consistent with the json one #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2417 +/- ##
==========================================
+ Coverage 67.15% 67.16% +0.01%
==========================================
Files 210 210
Lines 20523 20523
==========================================
+ Hits 13782 13785 +3
+ Misses 5602 5600 -2
+ Partials 1139 1138 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
umbynos
reviewed
Nov 13, 2023
umbynos
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Instead of using go struct to produce YAML output, we're now generating it starting from the JSON result using
sigs.k8s.io/yaml.pros:
cons:
What is the current behavior?
Currently, some values in the JSON output are missing when using the YAML format.
What is the new behavior?
The yaml output is now consistent with the JSON one.
Does this PR introduce a breaking change, and is titled accordingly?
Other information